Run all pipeline commands in docker (Proof of concept)#6
Closed
Staberinde wants to merge 8 commits intorun-pipeline-commands-locallyfrom
Closed
Run all pipeline commands in docker (Proof of concept)#6Staberinde wants to merge 8 commits intorun-pipeline-commands-locallyfrom
Staberinde wants to merge 8 commits intorun-pipeline-commands-locallyfrom
Conversation
2986631 to
48c079b
Compare
…ker for arbitrary makefile commands
f8e1067 to
408c99c
Compare
408c99c to
6257d0b
Compare
containeried way and some not Issue is aruond directory paths being different for dockerised and non-dockerised case Nicest solution might be a shell command Not sure that running the makefile outside the container is the best approach anymore
Contributor
Author
|
Deprecated in favour of #7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an idea on how to build on the changes made in #5 to provision make option to run arbitrary pipeline commands in docker
TODO
make DOCKERISED=1 collect:make: *** No rule to make target '/pipeline/collection/source.csv', needed by 'collect'. Stop.